PR: Add QtQuickWidgets #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please skip in Pyside2 to see if our tests pass there. |
|
@KurtJacobson, please remove your last commit. I'm going to fix the failures with our tests in PR #180. |
|
@ccordoba12 Excellent! I will revert 104b33c. |
|
@KurtJacobson, please rebase or merge with latest master to get the fixes. |
|
Also, a test is missing for your change. |
|
@ccordoba12 Will do, and I'll add the tests. Thank you! |
KurtJacobson
force-pushed
the
AddQtQuickWidgets
branch
from
342a41c
to
1eeffc2
Compare
KurtJacobson
force-pushed
the
AddQtQuickWidgets
branch
from
1d1e100
to
21385b3
Compare
|
1.6.0 is out, with this change. Enjoy! |
|
@ccordoba12 Thanks for the very quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for QtQuickWidgets.